Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding redirect to /stac/stac when using twitcher #382

Merged
merged 6 commits into from
Sep 21, 2023
Merged

Adding redirect to /stac/stac when using twitcher #382

merged 6 commits into from
Sep 21, 2023

Conversation

Nazim-crim
Copy link
Collaborator

@Nazim-crim Nazim-crim commented Sep 19, 2023 •
edited
Loading

Overview

Fix redirect when behind twitcher to automatically redirect to /stac/stac

Related Issue / Discussion

Notes

  • For permissions on magpie to be correctly applied on the stac ressource a child /stac is needed.
  • When using the current proxy .../stac redirect correctly to .../twitcher/ows/proxy/stac/stac but using twitcher/ows/proxy/stac/ does not.
  • This change make sure that api calls correctly redirect to twitcher/ows/proxy/stac/stac without having a recursive call to itself if /stac/stac is already in the url.

@Nazim-crim Nazim-crim self-assigned this Sep 19, 2023
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 19, 2023
@crim-jenkins-bot
Copy link
Collaborator

E2E Test Results

DACCS-iac Pipeline Results

Build URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/2071/
Result : failure

BIRDHOUSE_DEPLOY_BRANCH : stac-redirect
DACCS_CONFIGS_BRANCH : master
PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master
PAVICS_SDI_BRANCH : master

DESTROY_INFRA_ON_EXIT : true
PAVICS_HOST : https://host-140-216.rdext.crim.ca

PAVICS-e2e-workflow-tests Pipeline Results

Tests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1315/

NOTEBOOK TEST RESULTS 
    
[2023-09-19T18:40:24.027Z] ============================= test session starts ==============================
[2023-09-19T18:40:24.027Z] platform linux -- Python 3.9.16, pytest-7.3.1, pluggy-1.0.0
[2023-09-19T18:40:24.027Z] rootdir: /home/jenkins/agent/workspace/PAVICS-e2e-workflow-tests_master
[2023-09-19T18:40:24.027Z] plugins: anyio-3.6.1, dash-2.10.0, nbval-0.9.6, tornasync-0.6.0.post2, xdist-3.3.1
[2023-09-19T18:40:24.027Z] collected 237 items
[2023-09-19T18:40:24.027Z] 
[2023-09-19T18:40:32.052Z] notebooks-auth/test_thredds.ipynb ...........                            [  4%]
[2023-09-19T18:40:40.256Z] pavics-sdi-master/docs/source/notebooks/WCS_example.ipynb .......        [  7%]
[2023-09-19T18:40:48.653Z] pavics-sdi-master/docs/source/notebooks/WFS_example.ipynb ......         [ 10%]
[2023-09-19T18:40:57.667Z] pavics-sdi-master/docs/source/notebooks/WMS_example.ipynb .F......       [ 13%]
[2023-09-19T18:48:31.855Z] pavics-sdi-master/docs/source/notebooks/climex.ipynb ............        [ 18%]
[2023-09-19T18:48:31.855Z] pavics-sdi-master/docs/source/notebooks/eccc-geoapi-climate-stations.ipynb . [ 18%]
[2023-09-19T18:48:35.652Z] ...............                                                          [ 25%]
[2023-09-19T18:48:45.046Z] pavics-sdi-master/docs/source/notebooks/eccc-geoapi-xclim.ipynb .....    [ 27%]
[2023-09-19T18:48:52.425Z] pavics-sdi-master/docs/source/notebooks/esgf-dap.ipynb ......            [ 29%]
[2023-09-19T18:49:09.474Z] pavics-sdi-master/docs/source/notebooks/forecasts.ipynb ......           [ 32%]
[2023-09-19T18:49:10.851Z] pavics-sdi-master/docs/source/notebooks/jupyter_extensions.ipynb .       [ 32%]
[2023-09-19T18:49:17.917Z] pavics-sdi-master/docs/source/notebooks/opendap.ipynb .......            [ 35%]
[2023-09-19T18:49:22.690Z] pavics-sdi-master/docs/source/notebooks/pavics_thredds.ipynb .....       [ 37%]
[2023-09-19T18:54:27.434Z] pavics-sdi-master/docs/source/notebooks/regridding.ipynb ............... [ 44%]
[2023-09-19T18:55:44.391Z] .............                                                            [ 49%]
[2023-09-19T18:55:47.507Z] pavics-sdi-master/docs/source/notebooks/rendering.ipynb ....             [ 51%]
[2023-09-19T18:55:49.717Z] pavics-sdi-master/docs/source/notebooks/subset-user-input.ipynb ........ [ 54%]
[2023-09-19T18:56:06.383Z] .................                                                        [ 62%]
[2023-09-19T18:56:13.318Z] pavics-sdi-master/docs/source/notebooks/subsetting.ipynb ......          [ 64%]
[2023-09-19T18:56:14.703Z] pavics-sdi-master/docs/source/notebook-components/weaver_example.ipynb . [ 64%]
[2023-09-19T18:56:16.067Z] .FFFFFFFF                                                                [ 68%]
[2023-09-19T18:56:26.942Z] finch-master/docs/source/notebooks/dap_subset.ipynb ...........          [ 73%]
[2023-09-19T18:56:36.282Z] finch-master/docs/source/notebooks/finch-usage.ipynb ......              [ 75%]
[2023-09-19T18:56:38.193Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-1DataAccess.ipynb . [ 76%]
[2023-09-19T18:56:41.001Z] ......                                                                   [ 78%]
[2023-09-19T18:56:47.582Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-2Subsetting.ipynb . [ 79%]
[2023-09-19T18:57:02.171Z] .............                                                            [ 84%]
[2023-09-19T18:57:12.170Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-3Climate-Indicators.ipynb . [ 85%]
[2023-09-19T18:57:48.904Z] ....s.                                                                   [ 87%]
[2023-09-19T18:57:57.031Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-4Ensembles.ipynb . [ 88%]
[2023-09-19T18:58:11.799Z] ...                                                                      [ 89%]
[2023-09-19T18:58:26.700Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-5Visualization.ipynb . [ 89%]
[2023-09-19T18:58:52.219Z] ......                                                                   [ 92%]
[2023-09-19T18:58:55.327Z] notebooks/hummingbird.ipynb ............                                 [ 97%]
[2023-09-19T19:01:29.692Z] notebooks/stress-tests.ipynb ......                                      [100%]
[2023-09-19T19:01:29.692Z] 
[2023-09-19T19:01:29.692Z] =================================== FAILURES ===================================

@mishaschwartz
Copy link
Collaborator

@Nazim-crim do you mind summarizing the issue in DAC-580 here. I don't have access to that URL and I'm not sure what issue this is resolving. Thanks

fmigneault
fmigneault reviewed Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@fmigneault fmigneault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nazim-crim
I believe you also found out that the Magpie service/resources needed the nested stac/stac as well to secure access properly?

To make sure one does not create resources directly under the stac service, I think it would be wise to apply the permissions in https://github.com/bird-house/birdhouse-deploy/blob/master/birdhouse/optional-components/stac-public-access/config/magpie/config.yml.template#L11-L19 directly on a new stac resource under the stac service.

@Nazim-crim
Copy link
Collaborator Author

@mishaschwartz it's in the pr description

@mishaschwartz
Copy link
Collaborator

Wait, I'm also confused why there's no stac/config/magpie directory. At the very least, the Magpie providers definition should be there or else the current nginx definition won't work (unless we also enable stac-public-access).

Sorry, I should have noticed that earlier.

@mishaschwartz
Copy link
Collaborator

And also the current dependency structure will mean that stac will always be enabled if all-public-access is enabled.

  • all-public-access > stac-public-access > stac

That seems confusing as well.

There's some really weird things going on with the way this is set up. Am I looking at this wrong?

@Nazim-crim
Copy link
Collaborator Author

I think we should remove the stac-public-access and in the default.env of all-public-access and just have the definition of providers and permissions in /stac/config/magpie . Would that make more sense or is there another reason to have it separate. @mishaschwartz @fmigneault

@github-actions github-actions bot added the component/magpie Related to https://github.com/Ouranosinc/Magpie label Sep 20, 2023
@mishaschwartz
Copy link
Collaborator

@Nazim-crim I like your suggestion and I've made a branch with some suggested changes. Please check it out here (https://github.com/bird-house/birdhouse-deploy/compare/stac-permission-fixes)

Let me know if you'd like to incorporate these changes in this PR or if you'd like me to open a different PR as well

@Nazim-crim
Copy link
Collaborator Author

@mishaschwartz We can incorporate theses changes in this pr. Do you want me to pull your branch or are you gonna push it from your side here. Also just to make sure that there's a resource: /stac under both permission.

@fmigneault fmigneault mentioned this pull request Sep 20, 2023
Merged
@fmigneault
Copy link
Collaborator

Sorry, I didn't see all the following comments. Was already working on the fix.
See #383

@crim-jenkins-bot
Copy link
Collaborator

E2E Test Results

DACCS-iac Pipeline Results

Build URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/2075/
Result : failure

BIRDHOUSE_DEPLOY_BRANCH : stac-redirect
DACCS_CONFIGS_BRANCH : master
PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master
PAVICS_SDI_BRANCH : master

DESTROY_INFRA_ON_EXIT : true
PAVICS_HOST : https://host-140-133.rdext.crim.ca

PAVICS-e2e-workflow-tests Pipeline Results

Tests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1318/

NOTEBOOK TEST RESULTS 
    
[2023-09-20T15:10:07.090Z] ============================= test session starts ==============================
[2023-09-20T15:10:07.090Z] platform linux -- Python 3.9.16, pytest-7.3.1, pluggy-1.0.0
[2023-09-20T15:10:07.090Z] rootdir: /home/jenkins/agent/workspace/PAVICS-e2e-workflow-tests_master
[2023-09-20T15:10:07.090Z] plugins: anyio-3.6.1, dash-2.10.0, nbval-0.9.6, tornasync-0.6.0.post2, xdist-3.3.1
[2023-09-20T15:10:07.090Z] collected 237 items
[2023-09-20T15:10:07.090Z] 
[2023-09-20T15:10:14.635Z] notebooks-auth/test_thredds.ipynb ...........                            [  4%]
[2023-09-20T15:10:23.958Z] pavics-sdi-master/docs/source/notebooks/WCS_example.ipynb .......        [  7%]
[2023-09-20T15:10:33.651Z] pavics-sdi-master/docs/source/notebooks/WFS_example.ipynb ......         [ 10%]
[2023-09-20T15:10:42.806Z] pavics-sdi-master/docs/source/notebooks/WMS_example.ipynb .F......       [ 13%]
[2023-09-20T15:18:15.264Z] pavics-sdi-master/docs/source/notebooks/climex.ipynb ............        [ 18%]
[2023-09-20T15:18:15.264Z] pavics-sdi-master/docs/source/notebooks/eccc-geoapi-climate-stations.ipynb . [ 18%]
[2023-09-20T15:18:18.819Z] ...............                                                          [ 25%]
[2023-09-20T15:18:28.544Z] pavics-sdi-master/docs/source/notebooks/eccc-geoapi-xclim.ipynb .....    [ 27%]
[2023-09-20T15:18:35.491Z] pavics-sdi-master/docs/source/notebooks/esgf-dap.ipynb ......            [ 29%]
[2023-09-20T15:18:52.218Z] pavics-sdi-master/docs/source/notebooks/forecasts.ipynb ......           [ 32%]
[2023-09-20T15:18:53.603Z] pavics-sdi-master/docs/source/notebooks/jupyter_extensions.ipynb .       [ 32%]
[2023-09-20T15:19:01.688Z] pavics-sdi-master/docs/source/notebooks/opendap.ipynb .......            [ 35%]
[2023-09-20T15:19:06.562Z] pavics-sdi-master/docs/source/notebooks/pavics_thredds.ipynb .....       [ 37%]
[2023-09-20T15:22:29.098Z] pavics-sdi-master/docs/source/notebooks/regridding.ipynb ............... [ 44%]
[2023-09-20T15:23:59.246Z] .............                                                            [ 49%]
[2023-09-20T15:24:03.989Z] pavics-sdi-master/docs/source/notebooks/rendering.ipynb ....             [ 51%]
[2023-09-20T15:24:07.116Z] pavics-sdi-master/docs/source/notebooks/subset-user-input.ipynb ........ [ 54%]
[2023-09-20T15:24:31.900Z] .................                                                        [ 62%]
[2023-09-20T15:24:39.327Z] pavics-sdi-master/docs/source/notebooks/subsetting.ipynb ......          [ 64%]
[2023-09-20T15:24:41.232Z] pavics-sdi-master/docs/source/notebook-components/weaver_example.ipynb . [ 64%]
[2023-09-20T15:24:42.967Z] .FFFFFFFF                                                                [ 68%]
[2023-09-20T15:24:54.078Z] finch-master/docs/source/notebooks/dap_subset.ipynb ...........          [ 73%]
[2023-09-20T15:25:04.557Z] finch-master/docs/source/notebooks/finch-usage.ipynb ......              [ 75%]
[2023-09-20T15:25:07.092Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-1DataAccess.ipynb . [ 76%]
[2023-09-20T15:25:11.483Z] ......                                                                   [ 78%]
[2023-09-20T15:25:43.582Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-2Subsetting.ipynb . [ 79%]
[2023-09-20T15:26:40.914Z] .............                                                            [ 84%]
[2023-09-20T15:26:55.804Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-3Climate-Indicators.ipynb . [ 85%]
[2023-09-20T15:28:32.824Z] ....s.                                                                   [ 87%]
[2023-09-20T15:28:40.951Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-4Ensembles.ipynb . [ 88%]
[2023-09-20T15:28:55.714Z] ...                                                                      [ 89%]
[2023-09-20T15:29:10.624Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-5Visualization.ipynb . [ 89%]
[2023-09-20T15:29:35.136Z] ......                                                                   [ 92%]
[2023-09-20T15:29:38.721Z] notebooks/hummingbird.ipynb ............                                 [ 97%]
[2023-09-20T15:32:19.389Z] notebooks/stress-tests.ipynb ......                                      [100%]
[2023-09-20T15:32:19.389Z] 
[2023-09-20T15:32:19.389Z] =================================== FAILURES ===================================

@mishaschwartz
Copy link
Collaborator

Sorry, I didn't see all the following comments. Was already working on the fix.

@fmigneault no worries. That's funny, we were all working on the same thing. Let's use your PR and leave this one as is and I'll remove my branch once your PR is pulled in

tlvu
tlvu approved these changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@tlvu tlvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Approuve the spirit of the PR. Will let Francis have the final say since he knows more about Magpie config.

@fmigneault
Copy link
Collaborator

Updated to take into account changes in #383.
Will merge both PRs together before bump.

@crim-jenkins-bot
Copy link
Collaborator

E2E Test Results

DACCS-iac Pipeline Results

Build URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/2078/
Result : failure

BIRDHOUSE_DEPLOY_BRANCH : stac-redirect
DACCS_CONFIGS_BRANCH : master
PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master
PAVICS_SDI_BRANCH : master

DESTROY_INFRA_ON_EXIT : true
PAVICS_HOST : https://host-140-46.rdext.crim.ca

PAVICS-e2e-workflow-tests Pipeline Results

Tests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1321/

NOTEBOOK TEST RESULTS 
    
[2023-09-20T19:32:32.178Z] ============================= test session starts ==============================
[2023-09-20T19:32:32.178Z] platform linux -- Python 3.9.16, pytest-7.3.1, pluggy-1.0.0
[2023-09-20T19:32:32.178Z] rootdir: /home/jenkins/agent/workspace/PAVICS-e2e-workflow-tests_master@2
[2023-09-20T19:32:32.178Z] plugins: anyio-3.6.1, dash-2.10.0, nbval-0.9.6, tornasync-0.6.0.post2, xdist-3.3.1
[2023-09-20T19:32:32.178Z] collected 237 items
[2023-09-20T19:32:32.178Z] 
[2023-09-20T19:32:41.372Z] notebooks-auth/test_thredds.ipynb ...........                            [  4%]
[2023-09-20T19:32:54.669Z] pavics-sdi-master/docs/source/notebooks/WCS_example.ipynb .......        [  7%]
[2023-09-20T19:33:11.386Z] pavics-sdi-master/docs/source/notebooks/WFS_example.ipynb ......         [ 10%]
[2023-09-20T19:33:20.346Z] pavics-sdi-master/docs/source/notebooks/WMS_example.ipynb .F......       [ 13%]
[2023-09-20T19:43:40.490Z] pavics-sdi-master/docs/source/notebooks/climex.ipynb ............        [ 18%]
[2023-09-20T19:43:40.490Z] pavics-sdi-master/docs/source/notebooks/eccc-geoapi-climate-stations.ipynb . [ 18%]
[2023-09-20T19:43:43.239Z] ...............                                                          [ 25%]
[2023-09-20T19:43:52.636Z] pavics-sdi-master/docs/source/notebooks/eccc-geoapi-xclim.ipynb .....    [ 27%]
[2023-09-20T19:43:59.668Z] pavics-sdi-master/docs/source/notebooks/esgf-dap.ipynb ......            [ 29%]
[2023-09-20T19:44:15.995Z] pavics-sdi-master/docs/source/notebooks/forecasts.ipynb ......           [ 32%]
[2023-09-20T19:44:17.652Z] pavics-sdi-master/docs/source/notebooks/jupyter_extensions.ipynb .       [ 32%]
[2023-09-20T19:44:23.818Z] pavics-sdi-master/docs/source/notebooks/opendap.ipynb .......            [ 35%]
[2023-09-20T19:44:28.672Z] pavics-sdi-master/docs/source/notebooks/pavics_thredds.ipynb .....       [ 37%]
[2023-09-20T19:49:42.338Z] pavics-sdi-master/docs/source/notebooks/regridding.ipynb ............... [ 44%]
[2023-09-20T19:51:02.101Z] .............                                                            [ 49%]
[2023-09-20T19:51:05.412Z] pavics-sdi-master/docs/source/notebooks/rendering.ipynb ....             [ 51%]
[2023-09-20T19:51:07.630Z] pavics-sdi-master/docs/source/notebooks/subset-user-input.ipynb ........ [ 54%]
[2023-09-20T19:51:25.047Z] .................                                                        [ 62%]
[2023-09-20T19:51:33.188Z] pavics-sdi-master/docs/source/notebooks/subsetting.ipynb ......          [ 64%]
[2023-09-20T19:51:34.571Z] pavics-sdi-master/docs/source/notebook-components/weaver_example.ipynb . [ 64%]
[2023-09-20T19:51:35.923Z] .FFFFFFFF                                                                [ 68%]
[2023-09-20T19:51:47.489Z] finch-master/docs/source/notebooks/dap_subset.ipynb ...........          [ 73%]
[2023-09-20T19:51:56.080Z] finch-master/docs/source/notebooks/finch-usage.ipynb ......              [ 75%]
[2023-09-20T19:51:57.459Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-1DataAccess.ipynb . [ 76%]
[2023-09-20T19:52:00.527Z] ......                                                                   [ 78%]
[2023-09-20T19:52:08.684Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-2Subsetting.ipynb . [ 79%]
[2023-09-20T19:52:23.337Z] .............                                                            [ 84%]
[2023-09-20T19:52:35.560Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-3Climate-Indicators.ipynb . [ 85%]
[2023-09-20T19:53:19.618Z] ....s.                                                                   [ 87%]
[2023-09-20T19:53:27.798Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-4Ensembles.ipynb . [ 88%]
[2023-09-20T19:53:41.411Z] ...                                                                      [ 89%]
[2023-09-20T19:53:59.539Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-5Visualization.ipynb . [ 89%]
[2023-09-20T19:54:22.443Z] ......                                                                   [ 92%]
[2023-09-20T19:54:28.595Z] notebooks/hummingbird.ipynb ............                                 [ 97%]
[2023-09-20T19:57:02.688Z] notebooks/stress-tests.ipynb ......                                      [100%]
[2023-09-20T19:57:02.688Z] 
[2023-09-20T19:57:02.688Z] =================================== FAILURES ===================================

@crim-jenkins-bot
Copy link
Collaborator

E2E Test Results

DACCS-iac Pipeline Results

Build URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/2079/
Result : failure

BIRDHOUSE_DEPLOY_BRANCH : stac-redirect
DACCS_CONFIGS_BRANCH : master
PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master
PAVICS_SDI_BRANCH : master

DESTROY_INFRA_ON_EXIT : true
PAVICS_HOST : https://host-140-20.rdext.crim.ca

PAVICS-e2e-workflow-tests Pipeline Results

Tests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1323/

NOTEBOOK TEST RESULTS 
    
[2023-09-20T20:20:02.905Z] ============================= test session starts ==============================
[2023-09-20T20:20:02.905Z] platform linux -- Python 3.9.16, pytest-7.3.1, pluggy-1.0.0
[2023-09-20T20:20:02.905Z] rootdir: /home/jenkins/agent/workspace/PAVICS-e2e-workflow-tests_master@2
[2023-09-20T20:20:02.905Z] plugins: anyio-3.6.1, dash-2.10.0, nbval-0.9.6, tornasync-0.6.0.post2, xdist-3.3.1
[2023-09-20T20:20:02.905Z] collected 237 items
[2023-09-20T20:20:02.905Z] 
[2023-09-20T20:20:11.881Z] notebooks-auth/test_thredds.ipynb ...........                            [  4%]
[2023-09-20T20:20:23.213Z] pavics-sdi-master/docs/source/notebooks/WCS_example.ipynb .......        [  7%]
[2023-09-20T20:20:33.659Z] pavics-sdi-master/docs/source/notebooks/WFS_example.ipynb ......         [ 10%]
[2023-09-20T20:20:40.828Z] pavics-sdi-master/docs/source/notebooks/WMS_example.ipynb .F......       [ 13%]
[2023-09-20T20:33:45.162Z] pavics-sdi-master/docs/source/notebooks/climex.ipynb ............        [ 18%]
[2023-09-20T20:36:36.692Z] pavics-sdi-master/docs/source/notebooks/eccc-geoapi-climate-stations.ipynb . [ 18%]
[2023-09-20T20:36:36.692Z] ...............                                                          [ 25%]
[2023-09-20T20:36:43.836Z] pavics-sdi-master/docs/source/notebooks/eccc-geoapi-xclim.ipynb .....    [ 27%]
[2023-09-20T20:36:50.548Z] pavics-sdi-master/docs/source/notebooks/esgf-dap.ipynb ......            [ 29%]
[2023-09-20T20:37:07.349Z] pavics-sdi-master/docs/source/notebooks/forecasts.ipynb ......           [ 32%]
[2023-09-20T20:37:08.738Z] pavics-sdi-master/docs/source/notebooks/jupyter_extensions.ipynb .       [ 32%]
[2023-09-20T20:37:15.309Z] pavics-sdi-master/docs/source/notebooks/opendap.ipynb .......            [ 35%]
[2023-09-20T20:37:20.260Z] pavics-sdi-master/docs/source/notebooks/pavics_thredds.ipynb .....       [ 37%]
[2023-09-20T20:40:02.493Z] pavics-sdi-master/docs/source/notebooks/regridding.ipynb ............... [ 44%]
[2023-09-20T20:41:15.870Z] .............                                                            [ 49%]
[2023-09-20T20:41:17.087Z] pavics-sdi-master/docs/source/notebooks/rendering.ipynb ....             [ 51%]
[2023-09-20T20:41:19.336Z] pavics-sdi-master/docs/source/notebooks/subset-user-input.ipynb ........ [ 54%]
[2023-09-20T20:41:35.861Z] .................                                                        [ 62%]
[2023-09-20T20:41:43.070Z] pavics-sdi-master/docs/source/notebooks/subsetting.ipynb ......          [ 64%]
[2023-09-20T20:41:44.978Z] pavics-sdi-master/docs/source/notebook-components/weaver_example.ipynb . [ 64%]
[2023-09-20T20:41:53.526Z] .........                                                                [ 68%]
[2023-09-20T20:42:03.822Z] finch-master/docs/source/notebooks/dap_subset.ipynb ...........          [ 73%]
[2023-09-20T20:42:06.243Z] finch-master/docs/source/notebooks/finch-usage.ipynb EEEEEE              [ 75%]
[2023-09-20T20:42:07.888Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-1DataAccess.ipynb . [ 76%]
[2023-09-20T20:42:10.716Z] ......                                                                   [ 78%]
[2023-09-20T20:42:17.283Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-2Subsetting.ipynb . [ 79%]
[2023-09-20T20:42:34.328Z] .............                                                            [ 84%]
[2023-09-20T20:42:46.551Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-3Climate-Indicators.ipynb . [ 85%]
[2023-09-20T20:43:22.942Z] ....s.                                                                   [ 87%]
[2023-09-20T20:43:31.071Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-4Ensembles.ipynb . [ 88%]
[2023-09-20T20:43:46.645Z] ...                                                                      [ 89%]
[2023-09-20T20:44:01.534Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-5Visualization.ipynb . [ 89%]
[2023-09-20T20:44:24.506Z] ......                                                                   [ 92%]
[2023-09-20T20:44:26.982Z] notebooks/hummingbird.ipynb ............                                 [ 97%]
[2023-09-20T20:47:06.581Z] notebooks/stress-tests.ipynb ......                                      [100%]
[2023-09-20T20:47:06.581Z] 
[2023-09-20T20:47:06.581Z] ==================================== ERRORS ====================================

fmigneault added a commit that referenced this pull request Sep 21, 2023
@fmigneault
move STAC service Magpie definition under its component (#383)
7515db4 
## Overview

Move STAC service definitions under `components/stac` configuration.

## Changes

**Non-breaking changes**
- Move initial ``stac`` service Magpie definition under its component configuration.
  - Before this change, ``optional-components/stac-public-access`` was mandatory since the ``stac`` service under
    Magpie was not created otherwise, leading to "*service not found*" error when requesting the ``/stac`` endpoint.
  - Ensure that the first ``stac`` resource under ``stac`` service in Magpie is created by default.
    Without this resource being defined initially, it is very easy to forget creating it, which would not take into
    account the required ``/stac/stac`` request path to properly resolve the real endpoints where STAC API is served.
- Remove `optional-components/stac-public-access` dependency under `optional-components/all-public-access`
  to avoid indirectly enforcing `components/stac` when `optional-components/all-public-access` is enabled.
  Users that desire using `optional-components/stac-public-access` will have to add it explicitly to the list
  of `EXTRA_CONF_DIRS`.

- Rename `optional-components/stac-public-access/config/magpie/config.yml.template` to
  `optional-components/stac-public-access/config/magpie/permissions.cfg` in order to align
  with permissions-specific contents as accomplished with other components.

**Breaking changes**
- n/a

## Related Issue / Discussion

- Relates to #382
@github-actions github-actions bot added the ci/operations Continuous Integration components label Sep 21, 2023
@fmigneault fmigneault merged commit 2045cc5 into master Sep 21, 2023
@fmigneault fmigneault deleted the stac-redirect branch September 21, 2023 01:16
@crim-jenkins-bot
Copy link
Collaborator

E2E Test Results

DACCS-iac Pipeline Results

Build URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/2082/
Result : failure

BIRDHOUSE_DEPLOY_BRANCH : stac-redirect
DACCS_CONFIGS_BRANCH : master
PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master
PAVICS_SDI_BRANCH : master

DESTROY_INFRA_ON_EXIT : true
PAVICS_HOST : https://host-140-133.rdext.crim.ca

Infrastructure deployment failed. Instance has not been destroyed. @matprov

@crim-jenkins-bot
Copy link
Collaborator

E2E Test Results

DACCS-iac Pipeline Results

Build URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/2083/
Result : failure

BIRDHOUSE_DEPLOY_BRANCH : stac-redirect
DACCS_CONFIGS_BRANCH : master
PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master
PAVICS_SDI_BRANCH : master

DESTROY_INFRA_ON_EXIT : true
PAVICS_HOST : https://host-140-46.rdext.crim.ca

Infrastructure deployment failed. Instance has not been destroyed. @matprov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmigneault fmigneault fmigneault left review comments

@tlvu tlvu tlvu approved these changes

@mishaschwartz mishaschwartz Awaiting requested review from mishaschwartz mishaschwartz is a code owner

Assignees

@Nazim-crim Nazim-crim

Labels
ci/operations Continuous Integration components component/magpie Related to https://github.com/Ouranosinc/Magpie documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Nazim-crim @crim-jenkins-bot @mishaschwartz @fmigneault @tlvu